Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unspecified/any address "::" to enable IPv6 by default. #1364

Closed
wants to merge 1 commit into from
Closed

Added unspecified/any address "::" to enable IPv6 by default. #1364

wants to merge 1 commit into from

Conversation

spikebike
Copy link

License: MIT
Signed-off-by: Bill Broadley [email protected]

@jbenet jbenet added the backlog label Jun 12, 2015
@jbenet
Copy link
Member

jbenet commented Jun 12, 2015

This LGTM. thanks @spikebike

The once concern i have is what happens if a host does not support ip6? Could someone without ip6 test this?

I think perhaps the right thing to do here is to:

  • if any of the swarm addresses fails to bind, give a warning
  • if all of the swarm addresses fails to bind, also exit. (i.e. fatal error)

@whyrusleeping
Copy link
Member

hows this compare to #1076?

@jbenet
Copy link
Member

jbenet commented Jun 30, 2015

Closing in favor of #1076

@jbenet jbenet closed this Jun 30, 2015
@jbenet jbenet removed the backlog label Jun 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants